Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1440 +/- ##
========================================
Coverage 86.49% 86.49%
========================================
Files 340 340
Lines 86044 86047 +3
Branches 4833 4834 +1
========================================
+ Hits 74425 74428 +3
+ Misses 11619 11595 -24
- Partials 0 24 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with
\vertlosing itsstretchy="false"attribute when in infix form (where this is the default), but after semantic enrichment, being in pre- or postfix position (where it is not). This is similar to #1426, which handled explicit|characters, but missed handling\vert. The tests were updated to account for the difference.An alternative to this (and #1426) would be to adjust the filter that removes redundant attributes to leave explicit
stretchyattributes when themocontent is|. If you prefer that, I will redo this PR.Resolves issue mathjax/MathJax#3530